search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
177 stars 41 forks source link

Show watch progress in playlist view #1307

Closed Mjaethers closed 5 months ago

Mjaethers commented 5 months ago

Motivation and Context

Closes #1248 Much how the watch progress of a recording is displayed on the thumbnail of a stream on the course page, the watch progress of a recording is displayed in the playlist view.

Description

The stream API now also passes the stream progress in the returned StreamPlaylistEntry object. This data is passed to the Typescript Progress class constructor allowing the html to call functions on the progress so that it can be rendered in the same manner as on the course page.

Steps for Testing

  1. Log in
  2. Navigate to a recording
  3. Blend in the playlist
  4. Notice the the thumbnails show a progress bar

Screenshots

Screenshot 2024-01-11 at 17-38-19 TUM-Live Einführung Brauereiwesen VL 2 Wie mache ich Bier

YiranDuan721 commented 5 months ago

I think this solution would work, but unfortunately at the moment it doesn't work correctly for me. The watch progress displayed in the playlist does not match the one on the course page (or the progress saved in database): test_progress_in_playlist

Another small idea: I would like the width of the play progress not to exceed the width of the playlist, so that the playlist can be embedded perfectly in the page as it was, without the scrollbar at the bottom.

Mjaethers commented 5 months ago

Interesting, this is a bug I thought I had fixed, but I suppose I wasn't rigorous enough with different browsers and windows sizes. Thanks for looking into this, I'll try to fix it as soon as I have the time to.

YiranDuan721 commented 5 months ago

Ooops, it turns out that was due to me forgetting to clear the browser cache before testing. After that it works perfectly.

Sorry, my bad!

YiranDuan721 commented 5 months ago

I'm not sure about the failing check. It seems to be concerning some problem with user authentification? To test about that, also to trigger the test server deploying test again, I will push one commit here. I'm not sure, but I think you can directly work on this repository, instead of the forked one, to avoid this problem

Mjaethers commented 5 months ago

Okay thanks. I'll try without a fork next time, that might be it.