search

TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
177 stars 41 forks source link

Enh/update videojs #1318

Open SebiWrn opened 5 months ago

SebiWrn commented 5 months ago

Motivation and Context

Video.js has a new major version and we should update it for security and functionality purposes.

Description

Updated Video.js and fixed some new errors that occured due to a new system on the video.js side. Some workarounds because Video.js isn't really compatible to TypeScript, but only to JavaScript.

Also fixes "Prototype Pollution in JSON5 via Parse Method"

SebiWrn commented 5 months ago

Testserver is online at https://1318.test.live.mm.rbg.tum.de/

SebiWrn commented 5 months ago

I think the build error is only locally on your system because some files aren't updated, because VideoJsPlayer isn't used in any file anymore.

YiranDuan721 commented 5 months ago

I think the build error is only locally on your system because some files aren't updated, because VideoJsPlayer isn't used in any file anymore.

That's possible, I will do more checks locally. But the problem

The player stucks when I try to interact with the progress bar.

does occur on https://1318.test.live.mm.rbg.tum.de/. Maybe the build environment for test servers also has the same problem as my environment?

SebiWrn commented 5 months ago

Now I have the same problem locally, never had it before, I'll have a look into it