TUM-Dev / gocast

TUMs lecture streaming service.
https://live.rbg.tum.de/
MIT License
177 stars 41 forks source link

update if skip silence button is shown on seek #1326

Closed Mjaethers closed 2 months ago

Mjaethers commented 5 months ago

Motivation and Context

Fixes #1223. When jumping backward or forwards in the video player the "Skip pause" button is not updated, meaning that pressing it after jumping forwards could take you back again. Or when jumping into a silent segment it is not possible to immediately jump to the end of it without first unpausing.

Description

The function that checks whether this button should be displayed is called whenever the user seeks (jumps backwards or forwards)

Steps for Testing

Prerequisites:

  1. Log in
  2. Navigate to a Stream with silences
  3. Pause the Stream in a silent segment
  4. Jump past it, notice the "Skip pause" button vanishes
  5. Jump back into a silent segment, notice the button reappears

Screenshots

https://github.com/TUM-Dev/gocast/assets/61728152/9f4b5c14-fbf2-448f-b3c9-234f7bb0f966

github-actions[bot] commented 5 months ago

Your Testserver will be ready at https://1326.test.live.mm.rbg.tum.de in a few minutes.

Logins | Kurs1 | Kurs2 | Kurs3 | Kurs4 | | ---------------------------------------- | ------------------------- | ------------------------- | ------------------------- | | public | public | loggedin | enrolled | | prof1 | prof1 | prof2 | prof1
prof2 | | student1
student2
student3 | student1
student2 | student2
student3 | student1
student2 |