search

TVPT / VoxelSniper

The premiere long-distance brush editor for Minecraft
Other
128 stars 115 forks source link

Add missing ink performers. #177

Closed ayyy closed 11 years ago

ayyy commented 11 years ago

This adds a few missing ink performers: IP, ICP, IIP, IMP. (Sorry, I have no idea where the 'Merge remote-tracking branch' commit came from and I'm terrible with Git.)

Aerodog commented 11 years ago

You might've forked VoxelSniper before the latest push so it merged the latest upstream push into your fork.

Also, the ink-nophys brushes are pretty abstract. Why not use use combo-nophys?

ayyy commented 11 years ago

Oh... I didn't even think about that. I was after the ink performers and after noticing they didn't exist I just added them.

Aerodog commented 11 years ago

The ink performer might naturally be no-physics. Seems like a redundant commit. I rarely use ink performers to begin with (but I can't speak for everyone).

ayyy commented 11 years ago

It isn't no-phys naturally. And yea, it's a bit redundant now when you mentioned the combo performer, but I personally think it's worth adding, as there is a few occasions where they could be used and then theres people who don't think long enough to notice that the combo performer would work :p

Aerodog commented 11 years ago

Whenever I want to change the ink of something, combo is go-to. I totally forgot about ink.

MikeMatrix commented 11 years ago

I agree with Aero, although the commit seems good (except those missing empty last lines missing cringes) and it might be good to have a more complete set of performers for now. Gonna merge this.