search

TVPT / VoxelSniper

The premiere long-distance brush editor for Minecraft
Other
128 stars 115 forks source link

Fix OverlayBrush NullPointer #250

Closed ayyy closed 10 years ago

ayyy commented 10 years ago

249

ayyy commented 10 years ago

Definitely, I personally haven't used that much Apache commons or NumberUtils so I didn't even think of that :P

Do you want me to update the PR to use that code?

MikeMatrix commented 10 years ago

Leave it for now, we don't have Apache commons in our dependencies atm.

Mumfrey commented 10 years ago

Mike, apache commons is in bukkit!

gabizou commented 10 years ago

Not all apache commons is in bukkit. Not to mention, the version of apache commons is not the latest, so some classes/methods aren't available with the version supplied by bukkit/craftbukkit.

Mumfrey commented 10 years ago

I'm only going on what's in Minecraft Vanilla, which therefore must be in CraftBukkit, and I know that NumberUtils is there. So regardless of whether all of it is there (which you're right, it's not) the class in question is on the classpath and can be used. I wouldn't have posted that snippet otherwise.

gabizou commented 10 years ago

Ah I stand corrected then.

MikeMatrix commented 10 years ago

@Mumfrey That might be true, but you forget we use Bukkit (the API) not CraftBukkit (the Implementation with the dependencies). Thus unless we add Apache Commons or CraftBukkit (which I want to avoid, since updating it every time for the new version is a pain in the ass and with Bukkit we have compatibility for quite a while), we do not have access to Apache Commons or any of the Minecraft/CraftBukkit dependencies.

Mumfrey commented 10 years ago

Oh, I didn't realise you'd managed to divorce from CB, I thought you were still dependent on it. Good that you got shot of that.

MikeMatrix commented 10 years ago

:shipit: