search

TVPT / VoxelSniper

The premiere long-distance brush editor for Minecraft
Other
128 stars 115 forks source link

Fixing Handling of Performers and Cleaning Some Code #342

Open nlipiarski opened 5 years ago

nlipiarski commented 5 years ago

In this pull request, I updated how Voxel Sniper was handling performance modifiers on brushes to properly support the material, ink, and combo performers for both the placing and replacing of blocks. With this change, I updated the vi and vir change to take multiple block traits as arguments and ironed out some of the code in v and vr to better handle BlockStates and be more idiomatic. In addition, I cleaned up some of the naming conventions in SnipeData to be more consistent. The majority of the files affected by this pull request stem from that.

nlipiarski commented 4 years ago

OK, I split out the some changes into #343 and #344. I though I could stack the PRs, but I guess not so this one still includes those changes but once they are merged it should be fine.

nlipiarski commented 4 years ago

I rebased my branch onto the new changes, but there was some problem with line endings in PerformBrush.java that ended up making it look like the entire file was changed.

nlipiarski commented 4 years ago

@Deamon5550 @gabizou ping on this?