TVPT / VoxelSniper

The premiere long-distance brush editor for Minecraft
Other
128 stars 115 forks source link

Stencil brush requires a limit. #45

Closed ghost closed 11 years ago

ghost commented 12 years ago

today (26th of sept) someone crashed the server by pasting using stencil, many snipers know that stencil does not have a limit and exploit it - although is useful for most snipers some make mistakes, an example of this is now sat in the middle of bedlem, someone (my guess is andy or wyvill) had stencil pasted here and crashed the server, it appears they had copied part of spawn roughly from the center of the spawn area to the other end of the zah ship and pasted it into bedlam, because of this cisco asked me to speak to mike, in which he asked me to post it here, we need a limit on the brush, i personally recommend the same limits as copy pasta, which is 10000 blocks.

also please note this has also happened before when thimble did it and stenciled a large area of cubes which changed about 20-30 cubes, it was fixable and didn't break much but it was a long clean up.

MikeMatrix commented 12 years ago

Marked as enhancement and approved by me. Milestone for the next minor release due to Refactoring of a lot of classes and merge complications.

ghost commented 12 years ago

it also might be a good idea to wipe all previous stencils just in case that stencil is still there. i dont really know if thats true or not because i use WE rather than stencil brush.

itsjoekent commented 12 years ago

Cisco/Ridge would have to wipe them. But if your calculate before hand the blocks being pasted then this won't matter.

Also, isn't 10K a little tiny? I've seen people paste 50K without even dropping the TPS

ghost commented 12 years ago

10k is more then enough, remember that the original limit for copy pasta for LS was 1k, sniper = 10k and curator 100k, but that was back before whatever plugin which ran it was functioning properly, since then its been 10k for everyone - thats also one thing that needs changing at some point mike :P

but yeah, snipers are not allowed to paste anything huge, that was the job of a curator of their region or an admin. so 10k is perfect.