search

TWCable / grabbit

Grabbit - Fast Content Sync tool for AEM/CQ
Apache License 2.0
125 stars 64 forks source link

Issue 158 acl sync support #161

Closed jbornemann closed 7 years ago

jbornemann commented 7 years ago

Hey guys, this adds support for rep:policy nodes :-) Take a look when you have a chance @sagarsane @viveksachdeva

review-ninja commented 7 years ago

ReviewNinja

jbornemann commented 7 years ago

@sagarsane @viveksachdeva

jbornemann commented 7 years ago

Hey guys, if there are no code review comments on this; I'm going to move forward and get this in. After I finish my references branch, I was going to create a pre-release that we can use to try out all of these new features together.

viveksachdeva commented 7 years ago

@jbornemann : I will take a look at this in a day or two.. Is there a way to test this one?

jbornemann commented 7 years ago

@viveksachdeva I think it makes sense to test this out functionally with my other PR https://github.com/TWCable/grabbit/pull/163/files as 163 builds on this.

jbornemann commented 7 years ago

Thanks for the review @viveksachdeva. I've made some changes based on your suggestions. Feeling good about this?

viveksachdeva commented 7 years ago

Yeah.. +!