issue-7 stop job client

TWCable / grabbit

Grabbit - Fast Content Sync tool for AEM/CQ

Apache License 2.0

125 stars 64 forks source link

issue-7 stop job client #167

Open viveksachdeva opened 7 years ago

viveksachdeva commented 7 years ago

Old PR https://github.com/TWCable/grabbit/pull/146 had conflicts..

This one takes care of stopping jobs at client end.

review-ninja commented 7 years ago

jbornemann commented 7 years ago

Great! I'll take a look at this tomorrow

jbornemann commented 7 years ago

If you are curious about how close() behaves in our case, check out org.apache.http.impl.io.ChunkedInputStream.close() (which is wrapped by our entities EofSensorInputStream class). You can see it continues to read into a 2KB buffer on close, until EOF is reached.

sagarsane commented 7 years ago

This is a great start 👍 .. I agree with @jbornemann 's points as well.

jbornemann commented 7 years ago

https://github.com/TWCable/grabbit/commit/1ffe73f087204075e48901641abf0fb070d63b2a is merged, so this may help with your progress on this branch