search

TWCable / grabbit

Grabbit - Fast Content Sync tool for AEM/CQ
Apache License 2.0
125 stars 64 forks source link

Update to README for AEM 6.2 SP1 support #168

Closed jbornemann closed 7 years ago

jbornemann commented 7 years ago

FYI @viveksachdeva

review-ninja commented 7 years ago

ReviewNinja

viveksachdeva commented 7 years ago

@jbornemann : Installing this package did not fix the error for me.. Moreover it has an unmet dependency as I am not using any SP

jbornemann commented 7 years ago

@viveksachdeva sorry, I uploaded a new one.

jbornemann commented 7 years ago

Grabbit-Deserialization-Firewall-Configuration-1.0.zip

Any idea how to upload a generic file to https://bintray.com/twcable/aem/Grabbit#files/dependencies?

Everything I read is about uploading packages

jbornemann commented 7 years ago

Nevermind, got it figured out. You have to attach all files to a specific existing package version.

sagarsane commented 7 years ago

This is interesting ... getting caught up now.

sagarsane commented 7 years ago

Should we have the config be -amended? So that we don't overwrite incase the instance Grabbit getting installed to .. already has a config for the Deserialization service?

sagarsane commented 7 years ago

I think that way .. we can add only our stuff to the whitelist ...

Also, I didn't check thoroughly but do we need to update the filter.xml on grabbit so the /apps/grabbit/config/security doesn't get inadvertently wiped out when Grabbit is installed / re-installed ?

viveksachdeva commented 7 years ago

Agree with both the points from @sagarsane .. /apps/grabbit/config/security is getting wiped on on grabbit reinstall...

But on installing this package and running a sync from 6.2 -> 6.1 works fine..

jbornemann commented 7 years ago

Thanks guys. I didn't even think about filter.xml. I've updated the package, and the PR to accommodate.

-amended might work if we were dealing with just whitelist, but since blacklist is evaluated first, we have to remove those spring entries.

viveksachdeva commented 7 years ago

I am able to do content sync from 6.2 -> 6.1 with this package installed but when I uninstall grabbit, this deserialization config also goes away

jbornemann commented 7 years ago

Make sure you have the updated branch installed, and the updated package installed before you test the uninstall. Trying to uninstall when the old branch is already installed won't work.

viveksachdeva commented 7 years ago

@jbornemann : Yes I did install the latest package with the updated branch having

jbornemann commented 7 years ago

Sorry @viveksachdeva, I'm seeing what you are seeing now. Different behavior per install vs uninstall. I forgot how finicky working with the workspace filter is. I've got it down now. Promise :) Mind trying again?

viveksachdeva commented 7 years ago

No problem @jbornemann . I will try this one tomorrow..