search

TaDaa / vimade

An eye friendly plugin that fades your inactive buffers and preserves your syntax highlighting!
MIT License
486 stars 8 forks source link

Background color is not dimmed #26

Closed laggardkernel closed 4 years ago

laggardkernel commented 4 years ago

During my test, it seems only syntax highlight is dimmed but not background color for text or the bg for folded line.

Environment: iTerm2 without tmux, Nvim 3.0.8. Colorscheme: vim-one light mode.

TaDaa commented 4 years ago

Will look into this.

From what I remember, folds can be tricky because there is just one highlight group (Folded) and the highlighting can't really be controlled well to my knowledge - best way to make things look good is usually to clear the ctermbg/guibg for the Folded group.

TaDaa commented 4 years ago

This ended up being the case, basically the only highlight that works on folds is the Folded highlight (syntax and matchaddpos do not work).

I will add a flag for Vimade to override the colorscheme automatically. We should be able to able to calculate a Folded highlight that will work well both for the colorscheme and faded windows/buffers.

TaDaa commented 4 years ago

Folded is now supported for neovim and the other built-in highlight groups. Basegroups are enabled by default, but you can also customize the groups that vimade fades using g:vimade.basegroups.

Going to close this issue for now. Let me know if its not working as expected or if there are other issues.