search

Tangerine-Community / Tangerine-client-legacy

This repository has been moved to https://github.com/Tangerine-Community/Tangerine
Other
2 stars 4 forks source link

Linked survey validation failure #267

Open chrisekelley opened 8 years ago

chrisekelley commented 8 years ago

From Matt: On the linked survey linked to a grid test, when a student doesn't complete the grid test, only a subset of the server questions are supposed to show up. This happens but they are logical still on the page which causes the validation to fail.

It used to completely hide the question if it shouldn't be asked. With the most recent version of the APK, the container for the question is still displayed and the assessor cannot continue past it because the validation doesn't think that they have answered the question

Thing is,... the question is hidden like it's supposed to

chrisekelley commented 8 years ago

How to debug from MAtt: If you do not mark the last one read in the 5A (maybe less than 1/2 way through), then the container will show up on 5B but there will be no HTML in the container... The container 1) shouldn't show up and 2) should not be validated when the learner clicks next

My log:

[2/19/16, 10:50:15 AM] Chris Kelley: I didn’t mark anything on 5A, and proceeded to 5B, it does have quesrtions [2/19/16, 10:50:41 AM] Chris Kelley: I will next try marking up to the first half of 5A to reproduce the problem [2/19/16, 10:52:58 AM] Chris Kelley: I selected the second item in the second row. Clicking Next selects the last item.Proceeds to 5B, displays all questions. [2/19/16, 10:53:22 AM] Chris Kelley: Will now do it again, selecting the last item on the second row. [2/19/16, 10:55:33 AM] Chris Kelley: Marked the second item in second row. Clicking next. Please touch last item selected. Selected 3rd item, second row. Clicked next. Proceeded to Task 5B, displays questions. [2/19/16, 10:56:07 AM] Chris Kelley: Am I testing it correctly? [2/19/16, 10:56:19 AM] Chris Kelley: I will make an APK [2/19/16, 10:56:20 AM] Matt Finholt-Daniel: 5A is a complicated one because it also includes [2/19/16, 10:56:32 AM] Matt Finholt-Daniel: includes marking the middle... [2/19/16, 10:56:49 AM] Matt Finholt-Daniel: it doesn't matter which items were marked right or wrong... it matter what was marked as the list item read [2/19/16, 10:57:21 AM] Matt Finholt-Daniel: if you select an item about 1/2 way through as the last item read, it should only display a subset of the questions [2/19/16, 10:57:45 AM] Matt Finholt-Daniel: maybe 3/6 or 2/6 or 4/6 depending on which you asked

OK - I’ll select the last item, row 5 as last item read on 5A. I’ll also look at the logic in the admin edit to see what it is trying to do.

chrisekelley commented 8 years ago

[2/19/16, 11:21:12 AM] Chris Kelley: OK. Gonna debug this using Inspect with Chrome. [2/19/16, 11:24:28 AM] Chris Kelley: OK - this is interesting: the version of the browser that our Cordova container is using is a biit old - chrome 4..3 - whereas the current version for Webview is 47. This could be a bug that is fixed - I may be able to update the bundled browser to resolve this. Let me see. [2/19/16, 11:24:42 AM] Chris Kelley: This is probably why I cannot reproduce it localy.

chrisekelley commented 8 years ago

Changed crossview config to use the beta:

Inspect shows: org.rti.tangerine (43.0.2357.130)

The 5B task renders as it should.

Gonna switch back to the APK Matt sent to see which version is shows.

chrisekelley commented 8 years ago

Shows the same Chrome version! But the 5B task does not render properly. Need to get a better understanding of this issue.

chrisekelley commented 8 years ago

Matt has resolved the issue - there is a bug in the import, which he worked-around. Will open a new ticket for that. Will also open a ticket for upgrading Crosswalk.

skippskipp commented 8 years ago

This isn't restricted to imported assessments and can materialize in instruments which were authored on v.2be795a then moved to a current version of tangerine-client.