I just used _ as a convention to mark private fields. Now that TS is used, we can properly use the private keyword I think?
I guess this is used by other parts of our code outside this class though, in which case we can add a public getter for this field I think.
Same comment applies to basically all occurrences of fields with _ at the start.
Also for all methods with __ at the start, if they indeed aren't used outside the class at least.
I just used
_as a convention to mark private fields. Now that TS is used, we can properly use the private keyword I think? I guess this is used by other parts of our code outside this class though, in which case we can add a public getter for this field I think.Same comment applies to basically all occurrences of fields with
_at the start. Also for all methods with__at the start, if they indeed aren't used outside the class at least._Originally posted by @TarVK in https://github.com/TarVK/pixi-shadows/pull/10#discussion_r912748394_