search

TarVK / pixi-shadows

Adds dynamic shadows to PixiJS
https://tarvk.github.io/pixi-shadows/dist/
MIT License
52 stars 13 forks source link

`_shadowMapSprite` and `_shadowMapResultSprite` seem essentially identical #14

Open amir-arad opened 2 years ago

amir-arad commented 2 years ago

I think this is a mistake on my end, but _shadowMapSprite and _shadowMapResultSprite seem essentially identical? I think either one of these should be removed, or we should properly comment on how these 2 are used differently.

_Originally posted by @TarVK in https://github.com/TarVK/pixi-shadows/pull/10#discussion_r912822050_

scott-cornwell commented 1 year ago

@amir-arad _shadowMapResultSprite is not needed, I commented it out and everything still works