search

TarVK / pixi-shadows

Adds dynamic shadows to PixiJS
https://tarvk.github.io/pixi-shadows/dist/
MIT License
52 stars 13 forks source link

support pixijs 6+ and newer nodejs versions #9

Closed amir-arad closed 2 years ago

amir-arad commented 2 years ago

This is the first time I'm doing something like this in Pixi, I hope I didn't break anything.

please note that in the Application mixin, I did not have a good replacement for this.stage.parent = this.renderer._tempDisplayObjectParent and information about _tempDisplayObjectParent was scarce. I replaced it with this.stage.parent = this.stage and it... seems fine to me.

I also didn't know how to optionally import pixi-lights so it's not technically optional

TarVK commented 2 years ago

Oh super cool you fixed things for the latest version of pixi! I will probably have a look at things early next week, and merge if everything is fine (after creating a new branch to store the current version for pixi 4 in).

Also note that when I wrote this, I knew next to nothing about Pixi.js (still don't for the most part). So you probably didn't break anything. If some of my code seemed weird but you thought it might have been for a good reason you didn't understand; there probably was no reason and it was just me being stupid.

amir-arad commented 2 years ago

PR #10 includes all changes in this PR, including several fixes that were revealed thanks to use of strict type definitions.