Add unit tests and refactor some of the model code

TeachTechTaskForce / edumap

9 stars 12 forks source link

Closed hwayne closed 8 years ago

hwayne commented 8 years ago

This pull request makes the following changes:

Unit tests for lesson and code. Create testing database with rake db:test:prepare, run with rake test.
Some refactoring of the sorting and scoping logic, mostly to reduce duplication. For example, all new sorting methods will now automatically support desc without having to modify their where clauses.
A couple of minor bugfixes
Now works with any version of Ruby above 2.1.

hwayne commented 8 years ago

Since the searching logic is pretty gnarly I thought it'd be a good idea to show that it still works properly

pjsier commented 8 years ago

Thanks for taking this on! I just tried it out and it works great, feel free to post any issues of other things you think we need.