TeachTechTaskForce / edumap

9 stars 12 forks source link

Showing and hiding of intro text and search results does not work properly #91

Open kyaroch opened 8 years ago

kyaroch commented 8 years ago

Some irregularities I've noticed here:

emchang3 commented 8 years ago

The reason for the wonky behavior with the search results is because the showing/hiding that's being done is handled by the front end JavaScript independently of how each of those form actions interact with the back end, and specifically with filterrific. Filterrific, the way I see it, is a black box into which form actions disappear, and diktats come out.

I've altered the page layout to make sure the entry text behaves as we want it to. I will make a pull request shortly.

jared108 commented 8 years ago

error: conduct search then reset filters (in chrome) leads to the following problem (text displayed that shouldnt be there) image

emchang3 commented 8 years ago

That's intentional, unless you'd like the intro text to be shown only once.

jared108 commented 8 years ago

Error: time only displaying for a few of the bootstrap world search option. All times are listed in the data/curriculum/bootstrap.csv file
image

jonnorstrom commented 8 years ago

Made a PR for this. Added a gem to let Turbolinks and jQuery coexist without issues, then made event handler for the 'Reset Filter' button.