search

TeachTechTaskForce / edumap

9 stars 12 forks source link

Entry text will now go away. #94

Closed emchang3 closed 8 years ago

emchang3 commented 8 years ago

The problem was that the entry text was previously part of the results table. Now, the entry text is part of the base layout, and will not be controlled by filterrific, but rather by front end JavaScript.

I have not attempted to change any functionality pertaining to search results.

91

andyras commented 8 years ago

The welcome text does disappear when I search, but when I try a test filter (e.g. 4th grade), the welcome text stays. Is that something that can be dealt with outside of filterrific?

emchang3 commented 8 years ago

That's something I'm working on now. I will add more to the pull request if/when I have a solution, or not.

emchang3 commented 8 years ago

As the commit suggests, the filters now also remove entry text.

andyras commented 8 years ago

I tested again and when I filter the intro text still remains. (filter + keyword search does remove the text).

emchang3 commented 8 years ago

Odd, it works for me :/ screen shot 2016-05-19 at 3 39 50 pm

Edit: I tried it on Firefox, and it doesn't work there. I will have to figure out a cross-browser solution. Maybe resorting to jQuery.

emchang3 commented 8 years ago

Now works in Chrome and Firefox. Does not work in Safari. Have not tested Internet Explorer or Edge.