Closed andrewgazelka closed 6 years ago
@andrewgazelka I prefer a simple variable because you aren't doing any special initialization, don't need a time based initialization, and you aren't using a special API which only shows the front end prototype. Also it doesn't pollute the stack frame.
@isaacaj merge due to the fact that develop has been confirmed working and has been extensively tested. master
is for what WORKS, not what is NICE. However, changes recommended by @ritikmishra should still be done in develop imo (before competition). branch event-duluth
should be based off of master
, not develop
also imo.
May as well. Have a separate branch to deal with the suggested changes?
-- Ritik Mishra
On Sun, Mar 4, 2018 at 8:20 PM, Andrew Gazelka notifications@github.com wrote:
@isaacaj https://github.com/isaacaj pull due to the fact that it is confirmed working and has been extensively tested. master is for what WORKS, not what is NICE. However, changes recommended by @ritikmishra https://github.com/ritikmishra should be done in develop imo. branch event-duluth should be based off of master, not develop also imo.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Team-2502/RobotCode2018/pull/60#issuecomment-370291506, or mute the thread https://github.com/notifications/unsubscribe-auth/AEcQ7d-cpnXWQkWA2mIzcLPWi51N2Ej_ks5tbKDggaJpZM4SbMHH .
@donovanMaas I much prefer
getInstance()
over a static variableINSTANCE
.. it is more Java-like. What does everyone else think?