search

Team-BTMC / osu-radio

A music player for your local osu! library
30 stars 29 forks source link

Fixes some discord rpc issues #62

Open Foxinauci opened 1 month ago

Foxinauci commented 1 month ago

Hello, I tried fixing some discord-rpc issues I noticed. Mainly:

47 Spamming next causing discord rpc to desync.

Spamming pause and unpause causing discord rpc to show the play activity rather than pause on pause.

Clicking on the seekbar when paused causing discord rpc to show the play activity to show rather than the pause one. (Since it is still technically paused.)

My apologies if code is bad I mainly want opinions on it.

xDalete commented 1 month ago

when you do a pr that fixes a known issue you should mention it to make it clear just add "#" and the issue number to the description like this: #47 doing this, anyone who opens the issue will see that there's already a pr for that

Foxinauci commented 1 month ago

when you do a pr that fixes a known issue you should mention it to make it clear just add "#" and the issue number to the description like this: #47 doing this, anyone who opens the issue will see that there's already a pr for that

I think I did what you said. Except for that was there anything else you noticed with the code or pr that I could do better next time? Would like to know since I am not used to GitHub fully.

Foxinauci commented 1 month ago

I guess editing it in doesn't mention it in the issue though, I'll know for next time!

hrfarmer commented 1 month ago
image

can also just do it on the sidebar as well if it doesn't link through text

xDalete commented 1 month ago
image

can also just do it on the sidebar as well if it doesn't link through text

only collaborators can do that contributors cant see the edit button image

xDalete commented 1 month ago

I guess editing it in doesn't mention it in the issue though, I'll know for next time!

editing does mention it it just was already mentioned by my comment