chore: update ESLint config

Team-BTMC / osu-radio

A music player for your local osu! library

29 stars 29 forks source link

chore: update ESLint config #80

Closed brw closed 1 month ago

brw commented 1 month ago

Just updating the ESLint config a bit

Renamed eslint.config.mjs to eslint.config.js because using .mjs is unnecessary with type: "module" in package.json
Moved from @typescript-eslint/parser and @typescript-eslint/eslint-plugin to typescript-eslint
Add types packages for eslint
Add Solid eslint config
Remove unused/duplicate dependencies
Remove --fix from the lint script, add separate lint:fix script for that (makes more sense imo).
- ~~Still keep the old lint:check around for backwards compatibility~~

brw commented 1 month ago

@duduBTW I thought I'd fix the Solid lint errors/warnings but maybe it's better if you change it how you see fit so feel free to add to the branch

duduBTW commented 1 month ago

I'll take a look into the UI errors soon, should not be that hard to fix.

brw commented 1 month ago

are you still going to fix the rest of the warnings btw @duduBTW?

brw commented 1 month ago

oh or are those new warnings introduced by me merging master into this :Thinkies: I guess it might make more sense to just merge it now to avoid any newly added code going even more out of sync and maybe fix all of the warnings in one go later

brw commented 1 month ago

nvm I just checked. Those warnings did already exist before merging master into this

duduBTW commented 1 month ago

Most of the warning are on legacy components, like the Bar that will be replaced by the Slider, the tags that will be replaced on the new tags PR etc.

The only concerning warning I saw was on the useControllableState, however, it is complaining that the reactiveness will be lost because it is not used on jsx, but the result of useControllableState will be used on the jsx, the function is only passing this value down, that can be verified by the fact that the reactivity still works. It looks like eslint is just getting lost to me, but I could be wrong.

brw commented 1 month ago

I've been working on figuring out how to fix the reactivity warnings for useControllableState (it seems like ESLint actually does have a point, more on that later), but I think it's good to at least merge this for now and then I'll fix those issues in a separate PR

brw commented 1 month ago

I guess I shouldn't delete Bar.tsx actually, maybe we'll need it for something at some point? Should really clean up all of the dead code at some point though

brw commented 1 month ago

Would recommend squash merging btw