Team-BTMC / osu-radio

A music player for your local osu! library
30 stars 29 forks source link

Fix code scanning alert no. 1: Double escaping or unescaping #98

Open brw opened 1 month ago

brw commented 1 month ago

Fixes https://github.com/Team-BTMC/osu-radio/security/code-scanning/1

To fix the double escaping issue, we need to ensure that backslashes are escaped before any other characters. This way, any existing backslashes are correctly handled before other replacements are made. We will modify the changeSongHighlight function to first escape backslashes and then escape double quotes.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

brw commented 1 month ago

Hm yes, very interesting