Team-Let-s-Do / DoAPI

GNU Lesser General Public License v3.0
3 stars 5 forks source link

conflict with terraform reforged #1

Open Trinsdar opened 1 year ago

Trinsdar commented 1 year ago

seems this code: https://github.com/Cristelknight999/DoAPI/blob/87fcdd01ee89b0253e8c85697f3fea3119de34bf/forge/src/main/java/de/cristelknight/doapi/forge/mixin/boat/MixinShulkerEntity.java#L13-L19 causes a conflict with my port of terraform api: https://github.com/Reforged-Mods/Terraform-Reforged/blob/1.19-forge/terraform-wood-api-v1/src/main/java/com/terraformersmc/terraform/boat/impl/mixin/MixinShulkerEntity.java#L15 if you change to mixin extra's WrapOperation I can also change to use that

Cristelknight999 commented 1 year ago

Didn't know there is a terraform reforged mod. I'll definitely try to use mixin extra

Cristelknight999 commented 1 year ago

I fixed the crash with mixin extra, but that doesn't solve the incompatibility. Now boats from your terraforged version can't be seen on the client and it's just really bugged. probably because they have the same id

Cristelknight999 commented 1 year ago

Is this now called fixed?