search

Team-Pharos / FEC_Lighthouse

0 stars 5 forks source link

Unnecessary use of &nbsp #105

Open KKranzfelder opened 2 years ago

KKranzfelder commented 2 years ago

https://github.com/Team-Pharos/FEC_Lighthouse/blob/47b9ec0dc4d9036de296df743ecc2f592ea5d160/src/components/Overview/ProductInfo.jsx#L14

https://github.com/Team-Pharos/FEC_Lighthouse/blob/47b9ec0dc4d9036de296df743ecc2f592ea5d160/src/components/Overview/ProductInfo.jsx#L22

Description

Jake pointed out in an earlier in code review that it may be better to opt for {. } rather than using &nsbp. Save some text from needing to be compressed later.

File

FEC_Lighthouse/src/components/Overview/ProductInfo

Tasks

FangzhuoXi commented 2 years ago

So after Jake mentioned these. I went back and try it again {'. '}does not works for me. It will only create 1 space but if I want more than one then {' '} is not able to do that. not sure why

KKranzfelder commented 2 years ago

Huh interesting. Ignore this then!