TeamSpen210 / HammerAddons

Useful tweaks and content for Source Engine Games
123 stars 36 forks source link

`OnFizzled` output is not present on `prop_weighted_cube` but is somehow present on `prop_floor_button` #232

Closed movercell closed 1 year ago

movercell commented 1 year ago

Look at the name(i am not the only one who has the issue, my friend also has it)

TeamSpen210 commented 1 year ago

Hmm weird that it’s not on cubes. It should be on buttons, the output is in fact available and functional on all model-based entities. Though obviously it’d be rather unlikely for a button to end up in a situation where it can be fizzled.

movercell commented 1 year ago

oh, but yeah it's strange it isn't on cubes

The1stWii2 commented 1 year ago

It's because prop_floor_button inherits OnFizzled from BaseEntityAnimating, which isn't a base for prop_weighted_cube. The handful of other entities which have OnFizzled and don't inherit it from BaseEntityAnimating all manually define it. It might be a good idea to add a definition to BaseEntityPhysics, of which, it seems, most other model-based entities inherit from. inheritance

TeamSpen210 commented 1 year ago

Ahh whoops, need to check why BasePropPhysics doesn't inherit from BaseEntityAnimating. It would in code.