TeamSpen210 / HammerAddons

Useful tweaks and content for Source Engine Games
124 stars 36 forks source link

Rename 'Is not Looped' to 'Do not loop' in `ambient_generic` #260

Open electrovoyage opened 8 months ago

electrovoyage commented 8 months ago

Rename looping flag in ambient_generic to a more readable variant

vrad-exe commented 8 months ago

This probably isn't a good idea, because the flag doesn't actually control whether or not the sound loops, that's defined in the sound file itself. It just changes the behavior of certain entity inputs and not having it match the sound's inbuilt loop state can cause issues. (FYI, ambient_generic is an absolutely terrible entity, just look at how many bugs are listed on the VDC page.)

TeamSpen210 commented 8 months ago

Ideally we should find a non-negated wording too...

electrovoyage commented 8 months ago

Ideally we should find a non-negated wording too...

I wonder if it's possible to invert the flag in FGD or at least in the Postcompiler?

electrovoyage commented 8 months ago

This probably isn't a good idea, because the flag doesn't actually control whether or not the sound loops, that's defined in the sound file itself.

Yes, but HA can pack files, it's probably not hard to make it add loop markers into files (hopefully). Maybe then the flag can be renamed to something like 'disallow looping'?

vrad-exe commented 8 months ago

That would be useful, but should be done by adding a new keyvalue to the entity instead of modifying the behavior of an existing flag.

electrovoyage commented 8 months ago

...but should be done by adding a new keyvalue to the entity instead of modifying the behavior of an existing flag.

Oh yeah, i completely forgot how flags work