Fixes #143 and #144 - Githubissues

TechSpiritSS / Terminal-Portfolio

Terminal Style Portfolio made with HTML / CSS / JS

MIT License

64 stars 83 forks source link

Fixes #143 and #144 #146

Closed Siddhesh-Agarwal closed 1 year ago

Siddhesh-Agarwal commented 1 year ago

Fixes

Fixes #143 by @Siddhesh-Agarwal Fixes #144 by @Siddhesh-Agarwal

Types of changes

[x] Bug/Hot fix (non-breaking change which fixes a bug)
[ ] New feature (non-breaking change which adds a functionality/feature)
[ ] Refactoring Old Code ( non-breaking change replacing already existing code)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Improved speed by Using a pre-sorted list instead of sorting it every time (#143)
Security improvement: used Function instead of eval (#144)

Preview Link

Here's my preview

Checklist:

[x] I have read the CONTRIBUTING guidelines in repository.
[x] My pull request has a descriptive title and is attached to an existing issue.
[x] I haven't repeated the code and it follows established code style of repository.
[x] My branch is up-to-date with upstream branch.

TechSpiritSS commented 1 year ago

Great 🚀