search

TechSpiritSS / Terminal-Portfolio

Terminal Style Portfolio made with HTML / CSS / JS
MIT License
62 stars 82 forks source link

done changes in galaxy ,vibrant, nature,matrix and metalic theme #155

Closed Nehaaa3121 closed 1 year ago

Nehaaa3121 commented 1 year ago

i have resolved the issue .kindly approve my PR. issue number :- #153

Fixes #153 by @TechSpiritSS

TechSpiritSS commented 1 year ago

preview link?

Nehaaa3121 commented 1 year ago

https://nehaaa3121.github.io/Terminal-Portfolio/

here is my preview link

TechSpiritSS commented 1 year ago

Why have you changed the colors of existing themes?

Nehaaa3121 commented 1 year ago

for making UI design better. you can see the differences in previous design themes aren't that much attractive.

TechSpiritSS commented 1 year ago

I don't think color scheme was an issue.

TechSpiritSS commented 1 year ago

Instead of changing colors, make the design consistent across the themes as there's difference in sizing properties across the themes.

Nehaaa3121 commented 1 year ago

you can check the galaxy and vibrant themes, they are of the same design that's why I have brought changes in all the themes.

TechSpiritSS commented 1 year ago

yes but that wasn't an issue

Nehaaa3121 commented 1 year ago

yes but that wasn't an issue

no problem , I have made these changes only because I thought that UI design plays an important role in any project.

TechSpiritSS commented 1 year ago

Yes UI plays an important part in any project, if you feel current themes aren't that appealing you're free to create a team of your own and send a PR.