fixed the theme reset issue on reloading - Githubissues

TechSpiritSS / Terminal-Portfolio

Terminal Style Portfolio made with HTML / CSS / JS

MIT License

62 stars 82 forks source link

fixed the theme reset issue on reloading #77

Closed BiswajitSahoo-tech closed 1 year ago

BiswajitSahoo-tech commented 1 year ago

Fixes

Fixes #70 by @BiswajitSahoo-tech

Types of changes

[x] Bug/Hot fix (non-breaking change which fixes an bug)
[ ] New feature (non-breaking change which adds a functionality/feature)
[ ] Refactoring Old Code ( non-breaking change replacing already existing code)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

I fixed an issue, where on reloading theme choice gets reset. I removed a line of code that caused this. setTheme("default");

This is necessary to fixed because it is essential to save the user preference of theme and set user chosen theme whenever that user visits the site

Preview Link

[Before reload]
[After reload]

Checklist:

[x] I have read the CONTRIBUTING guidelines in repository.
[x] My pull request has a descriptive title and is attached to an existing issue.
[x] I haven't repeated the code and it follows established code style of repository.
[x] My branch is up-to-date with upstream branch.

TechSpiritSS commented 1 year ago

Great 👍 but I'm not sure 1 line code will be accepted by hacktoberfest