search

TechSpiritSS / Terminal-Portfolio

Terminal Style Portfolio made with HTML / CSS / JS
MIT License
62 stars 82 forks source link

[Bug]: Github command should be asynchronous #81

Closed SadashayKanungo closed 1 year ago

SadashayKanungo commented 1 year ago

Contact Details

sadashay01@gmail.com

What happened?

The github command fetches the github api to get a user's details. In the current code, this fetch is not done asynchronously. So we are getting the output after a new line has been created in the terminal. Here is the screenshot of the bug. issue

What should have happened?

The github user details should be prefetched. When github command is entered, the only activity should be printing the prefetched details since new line creation is implemented with fixed time delay. This is the implementation style used in contributors command that does have this issue.

What browsers are you seeing the problem on?

No response

Version

No response

Relevant log output

No response

SadashayKanungo commented 1 year ago

Hey @TechSpiritSS please assign this issue to me.

TechSpiritSS commented 1 year ago

Sure👍