search

TechnionYP5777 / Smartcity-Smarthouse

Smartcity-Smarthouse
11 stars 5 forks source link

GuiBinderObject Bug? #215

Closed ylevv closed 7 years ago

ylevv commented 7 years ago

This is from the stove app. I changed both time and temperature thresholds with mouse + keyboard and not with the up / down arrows.

bug

You can see that both time and temperature current values are higher than their thresholds, yet the numbers in the status section are not red.

@RonGatenio is it possible the bug is in GuiBinderObject?

RonGatenio commented 7 years ago

About the temperature (it is misspelled in the app 😁): Try to play with the sensors temperature bar... If you change this param in the app, and there isn't any new message from the sensor, the color won't update (I will fix this later...)

About the time... I have no idea... maybe you didn't press ENTER, so the value didn't really change. If that is the case, I will add an indicator that the value use changed (like in the text field of the configuration region)

ylevv commented 7 years ago

maybe you didn't press ENTER, so the value didn't really change.

That's indeed the case for both fields... 😅 Maybe an "Update" button will be more intuitive (I had no idea ENTER would do the update).

EliaTraore commented 7 years ago

Maybe a "saved" label showing for few seconds after the value have been save will be enough of an indication?

ylevv commented 7 years ago

But then if the user don't know it should appear, he / she might think the value was updated while it did not.

RonGatenio commented 7 years ago

I will make the spinner like the text field: text

Both ENTER and OK will work

RonGatenio commented 7 years ago

Can someone please fix the misspelled "tempeture" to "temperature"? 😁

ylevv commented 7 years ago

Looks great! I can do it 😁