search

TechnionYP5779 / team4

29 stars 2 forks source link

Consolidate classres Range and range #108

Closed dormaayan closed 5 years ago

dormaayan commented 5 years ago

From @yossigil on November 14, 2018 9:9

if you created class Range (capitalized).

The correct design should have three (internal?) classes, one for infinite range bounded above, another for infinite bounded below and a third for a finite range.

for example, range.to(3).to(2) generates an error, range.to(3).fron(2) creates a finite range,

the person responsible for this should not be the person who wrote class Range

Copied from original issue: TechnionYP5779/team6#77

dormaayan commented 5 years ago

This issue was moved to TechnionYP5779/team1#78

dormaayan commented 5 years ago

This issue was moved to TechnionYP5779/team2#63

dormaayan commented 5 years ago

This issue was moved to TechnionYP5779/team3#81

yossigil commented 5 years ago

use lower case since this is fluent

yossigil commented 5 years ago

hint, you need three different classes, for the three kinds of ranges, each supporting different functions

ron4548 commented 5 years ago

@yossigil I don't understand. You said consolidate. We had 2 classes named Range, we moved the functionality of one of them to the other. Where should three classes come from?

0xYuval commented 5 years ago

Sprint-Zero is done.