TechnionYP5779 / team4

29 stars 2 forks source link

Increase code coverage to 60%; for this you need to run "coverage as" #52

Closed yossigil closed 5 years ago

dormaayan commented 6 years ago

Please assign all the team members to this issue, and refrence all the other relevant issues here

menhel commented 6 years ago

Estimated: 3 hours

yossigil commented 5 years ago

LET'S TRY AND SEE.

ron4548 commented 5 years ago

Current coverage is 30.8% image The following issues should increase code coverage upon completion: #29 #32 #34 #40 #41 #42 #44 #46

menhel commented 5 years ago

Current coverage: 48.1% image

ameeramer commented 5 years ago

Current Coverage: 54.0%

image

0xYuval commented 5 years ago

image

Current coverage 57.9%

dormaayan commented 5 years ago

Keep going!

ameeramer commented 5 years ago

image

ameeramer commented 5 years ago

took 4 hrs.

yossigil commented 5 years ago

image Coverage should be of code, src/main. You are currently at 33%...

0xYuval commented 5 years ago

image current is 42%

0xYuval commented 5 years ago

image current 48.2%

ameeramer commented 5 years ago

image

0xYuval commented 5 years ago

image

ameeramer commented 5 years ago

image

menhel commented 5 years ago

Note: the badge in the readme is showing only 55%. This is due to the way Codecov's formula, which treat partials as 0% coverage instead of their actual percentage. This is not the case in Eclipse, and as we were instructed to check ourselves with Eclipse, this issue is still closed.

See snapshot from Codecov's website: image