search

Techtonica / curriculum

This repo contains the curriculum of Techtonica, a free tech training program for women and non-binary adults with low incomes.
Creative Commons Attribution Share Alike 4.0 International
614 stars 496 forks source link

validate version bump PRs in "keyboard shortcuts" repo #1576

Open alodahl opened 3 years ago

alodahl commented 3 years ago

Please test these version bump PRs locally to ensure that our package.json commands run without any new warnings or errors, and that the app behaves as expected. The UI should behave the same as the live site: https://techtonica.github.io/keyboard-shortcuts-practice/ Please let us know if we're clear to merge, or if there are issues. Gracias!

version bump PRs to review: https://github.com/Techtonica/keyboard-shortcuts-practice/pulls

stale[bot] commented 2 years ago

Although it may very well be a good idea, this issue has not had recent activity and is unlikely to be worked on. Consider creating your own pull request for the issue if that is feasible. If no further activity occurs, this will be closed in 14 days. Thank you for your contribution.

danisyellis commented 2 years ago

Before starting this, I tested the code as it currently is. I saw that a) you say that "The UI should behave the same as the live site" but when testing the site after using npm startor npm run dev, the app doesn't give the "you were slower..." or "you were faster..." info like the live site does. Basically, everything works the same, but the wording is a little different. b) running npm start:prod fails with this error: Error: Dialect needs to be explicitly supplied as of v4.0.0 at new Sequelize

I'm assuming these things are what's expected from this repo and tested the dependabot PRs with the intention to only flag problems if I saw any different behavior. I tested all 5 dependabot PRs currently in the repo and didn't see any other issues, so I've approved each of them.

Last note: when I test dependabot PRs for my own repo, I test each one individually, merge it in, and then test the next, on the offchance that one affects the next. In this case, since I've verified them individually, and none of them are major version changes, I think they can all be merged in at once. But then there should be one last verification once they're all in!

I think you've made me a maintainer on the keyboard shortcuts repo, so if you want, I can do the merging and final verification. I just wanted to check my assumptions above before doing that.

I hope getting these version bumps verified makes it easier to work on any other issues or features you're hoping to get done :-)

alodahl commented 2 years ago

Thanks Dani! I'm fine with you merging things in yourself. I think that I may have messed things up as I was trying to merge "backend" into main today, so sorry if I did.

alodahl commented 2 years ago

If you'd like to make a tiny PR that just fixes a typo somewhere, I can approve it so this counts for Hacktoberfest