search

Tecnativa / doodba

Base image for making the creation of customized Odoo environments a piece of cake
Apache License 2.0
423 stars 303 forks source link

Independent wkhtmltopdf #494

Open amon-ra opened 2 years ago

amon-ra commented 2 years ago

This pull try to solve Tecnativa/doodba#4039 . It will load wkhtmltopdf from an external docker image in port 8080.

theangryangel commented 2 years ago

Forgive me if I’m wrong, as I’m reading this PR on my phone, but this looks like a major breaking change?

As a very grateful user of Doodba, I like the idea of this in theory, but if it could be opt in and keep the existing functionality I feel it would be much more likely to be merged…

amon-ra commented 2 years ago

Now you can use build arg WKHTMLTOPDF_SKIP=1 to skip wkhtmltopdf build and use the new binary, there are no breaking changes now

bosd commented 8 months ago

@amon-ra Can you re-trigger tests?