search

Tecnativa / doodba

Base image for making the creation of customized Odoo environments a piece of cake
Apache License 2.0
423 stars 302 forks source link

[ADD] New geoip configuration file to provide odoo_version>=17.0 compatibility #601

Closed josep-tecnativa closed 6 months ago

josep-tecnativa commented 6 months ago

CC @Tecnativa TT48174 In order to fix this issue, https://github.com/Tecnativa/doodba/issues/600

Not tested yet.

pedrobaeza commented 6 months ago

This only applies to v17. Why are you doing this in all versions?

josep-tecnativa commented 6 months ago

This only applies to v17. Why are you doing this in all versions? The changes I've made are to use the configuration file 60-geoip.conf for versions < 17.0, and for versions >= 17.0, to use 70-geoip.conf. To achieve this, for versions <17.0, I delete the file 70-geoip.conf: RUN rm common/conf.d/70-geoip.conf And for version 17.0, I delete 60-geoip.conf: RUN rm common/conf.d/60-geoip.conf

ap-wtioit commented 6 months ago

This would probably also need to be reflected in the test code:

                    # verify that geoip database is configured
                    (
                        "grep",
                        "-R",
                        "geoip_database = /opt/odoo/auto/geoip/GeoLite2-City.mmdb",
                        "/opt/odoo/auto/odoo.conf",
                    ),
pedrobaeza commented 6 months ago

Superseded by #603