Tecnativa / doodba

Base image for making the creation of customized Odoo environments a piece of cake
Apache License 2.0
423 stars 302 forks source link

[IMP] tests: add test for screencast #602

Closed ap-wtioit closed 6 months ago

ap-wtioit commented 6 months ago

and verify artifacts are stored

as discussed with @chienandalu we should add a test to ensure chrome is working as expected in doodba for http test cases

This is failing for 17.0 (showing that the test is detecting missing artifacts) and should start getting passes once https://github.com/odoo/odoo/pull/156738 lands in 17.0.

Info @wt-io-it

pedrobaeza commented 6 months ago

Thanks for improving this, Andreas. Waiting for the merge of the other PR to merge this one.

ap-wtioit commented 6 months ago

edit: fixed in 6233a7fad4571ac08e2f8fc04ca8461a91e9133b

pedrobaeza commented 6 months ago

Something that I should fix? How?

ap-wtioit commented 6 months ago

no, i will handle it, i need to use the same docker-compose + sub_env file as in other tests that expose files / directories (but i copied from smallest and my local uid is 1000 so i didn't notice that when testing locally)

ap-wtioit commented 6 months ago

Notes for/from testing:

chienandalu commented 6 months ago

This is failing for 17.0 (showing that the test is detecting missing artifacts) and should start getting passes once odoo/odoo#156341 is merged.

Looks like it's already merged :)

ap-wtioit commented 6 months ago

Oh i got the wrong one, seems the forward porting of "add test for screencast" is stuck at 16.4 and no forward port PR is created for 17.0 yet.

chienandalu commented 6 months ago

Oh, I didn't double check either :sweat_smile:

ap-wtioit commented 6 months ago

now we have the test also in 17.0 https://github.com/odoo/odoo/blob/17.0/odoo/addons/base/tests/test_http_case.py, can anybody retry the test?

chienandalu commented 6 months ago

I just hit it :)

ap-wtioit commented 6 months ago

ok, doodba is using OCB as default, so the test did not work because test_screencasts is still missing there but it will land there soon enough i guess.

chienandalu commented 6 months ago

Oh, yeah. Let's wait for tomorrow then