Tecnativa / doodba

Base image for making the creation of customized Odoo environments a piece of cake
Apache License 2.0
423 stars 302 forks source link

[FIX] Fix docker image tags and ghcr.io auth credentials #604

Closed PCatinean closed 5 months ago

PCatinean commented 5 months ago

Hi @pedrobaeza small fix incoming:

  1. The tags which are pushed should now be as before - {ODOO_VERSION}, {ODOO_VERSION}-onbuild and latest, latest-onbuild (where applicable)
  2. The push to ghcr.io failed with the default credentials, I have switched them to the old ones hoping they will pass this time. If this also fails maybe you need to look into the permissions of the default github.repository_owner / secrets.GITHUB_TOKEN since authentication was sucessful.

Also after this works you would need to delete the extra {ODOO_VERSION}onbuild (with the missing -)

Fingers crossed :crossed_fingers:

PCatinean commented 5 months ago

@pedrobaeza tests have passed, feel free to merge when you have some time

PCatinean commented 5 months ago

@pedrobaeza it seems to have worked, all jobs passed and the images now have both architectures available for download.

Last touch would be to delete the stale {ODOO-VERSION}onbuild images like these ones

Screenshot from 2024-03-20 19-07-59

pedrobaeza commented 5 months ago

I'm not sure how the images are bridged to Docker Hub, as the workflow are supposed to be pushed to ghcr.io, and there, I don't see the other images: https://github.com/tecnativa/doodba/pkgs/container/doodba/versions?page=1

Do you know how this works?

PCatinean commented 5 months ago

In the initial PR merged I had two bugs:

  1. Added {ODOO_VERSION}onbuild instead of just {ODOO_VERSION}
  2. Credentials used for ghcr.io were different and the user did not have permission to push

For this reason the {ODOO_VERSION}onbuild made it to the docker hub but not ghcr.io. This should not happen any more after the fix and I see the latest push worked well for https://github.com/tecnativa/doodba/pkgs/container/doodba