search

Tecnativa / doodba

Base image for making the creation of customized Odoo environments a piece of cake
Apache License 2.0
423 stars 301 forks source link

Use --internal with sane defaults in scaffoldings #98

Closed yajo closed 6 years ago

yajo commented 6 years ago

It's interesting that in the scaffolding there has been the fakeinbox and fakesmtp containers made to isolate restored backups in devel/test environments from making requests to the outside world, specifically when attempting to contact servers.

However, it turns out that since Docker 1.10, we can create networks with the --internal flag, which restricts access to the outside world perfectly fine (see https://github.com/moby/moby/pull/19276).

We can use that instead of using some of the proxies. It should be easier to understand for newcomers, and easier to maintain for oldcomers.

pedrobaeza commented 6 years ago

IMO we should replace fakesmtp for providing a mail catcher like odoo.sh does.

yajo commented 6 years ago

Yes, also. I opened #101 for that.