Telenav / cactus

Modules for building the KivaKit Java framework.
Apache License 2.0
0 stars 1 forks source link

invalid pom.xml in telenav-superpom-lexakai #61

Closed jonathanl-telenav closed 2 years ago

jonathanl-telenav commented 2 years ago

I believe the configuration should go inside the execution element. This might explain why it's not updating readmes.


                    <plugin>
                        <groupId>com.telenav.cactus</groupId>
                        <artifactId>cactus-maven-plugin</artifactId>
                        <executions>
                            <execution>
                                <id>lexakai</id>
                                <phase>install</phase>
                                <goals>
                                    <goal>lexakai</goal>
                                </goals>
                            </execution>
                        </executions>
                        <configuration>
                            <verbose>true</verbose>
                            <overwrite-resources>true</overwrite-resources>
                            <update-readme>true</update-readme>
                        </configuration>
                    </plugin>
timboudreau commented 2 years ago

It can go in either place (specific configuration overrides configuration for the plugin entry which overrides configuration from the superpom), but I have moved it.