search

Tencent / LuaHelper

LuaHelper is a High-performance lua VSCode plugin, Language Server Protocol for lua.
Other
617 stars 93 forks source link

Why does the extension needs to access Tencent Cloud? #142

Closed melMass closed 1 year ago

melMass commented 1 year ago

Hi,

Is there a way to optout?

Thanks

https://github.com/Tencent/LuaHelper/blob/cc916454171f5d70f18ff2bc6229ba2059d5b9f0/luahelper-lsp/langserver/get_online_req.go#L37

image
qycyfjy commented 1 year ago

After a brief glance, https://github.com/Tencent/LuaHelper/blob/cc916454171f5d70f18ff2bc6229ba2059d5b9f0/luahelper-lsp/langserver/online_report.go#L8 will be uploaded if this option is checked(check the img below), or it will only upload your system version for counting the number of people online. coding as an online game? image

But it looks like there is no option to completely forbid the connection, maybe you could fork the repo and comment out this line https://github.com/Tencent/LuaHelper/blob/cc916454171f5d70f18ff2bc6229ba2059d5b9f0/luahelper-lsp/langserver/initialize.go#L223

melMass commented 1 year ago

Thanks for the insights! I guess it's just basic analytics, I wish there was an option to just remove it all together. Do they accept PRs?

melMass commented 1 year ago

I'll PR it and see if it's accepted!