Closed ila-embsys closed 4 weeks ago
Thanks!! But I think that it's better to do this conversion before to run Edalize: https://github.com/TerosTechnology/vscode-terosHDL/blob/dev/packages/colibri/src/project_manager/tool/edalize/edalize.ts#L80
In other case this can break save/load feature in global TerosHDL.
In other case this can break save/load feature in global TerosHDL.
I'm not sure that I clearly understand what exactly did you mean, but I checked mentioned 'save/load' feature and noticed that the changes affects saving project to the file. Did you mean that?
Now I'm confused why that happens. However, I guess that previously TerosHDL's project saving file was a kind of Edam format and now it is not. But it still uses function names like 'save_edam_yaml'. Am I right?
If so, that conversion should be outside 'get_edam_json' function. Did you mean something like that, when you said that the conversion is better to did before to run Edalize?
In other case this can break save/load feature in global TerosHDL.
This fixed by adding manual choosing whether edam json should be generated with standartized file_type
or not. The default is TerosHLD's format.
it looks perfect, thank you!!
Edam's
File
field must contain thefile_type
in a format likevhdlSource-2008
.Latest TerosHDL's project structure changes have a different approach for version storage. It is done by storing a version information in a separate
file_version
field, whilefile_type
still used as a file type. For example:file_type
isvhdlSource
andfile_version
is2008
.So that change pass the file information structure to Edalize in a wrong format. That is cause of loosing version information.
To fix that, the file type and the file version must be combined back. At least, I guess it must be for
verilogSource-2005
andvhdlSource-2008
.However, I'm no sure what version Edam file assumes if
file_type
doesn't contain explicit version. So the fix is discussionable. Also, I didn't check other side effects of project structure change. This changes effectively fix recognition ofvhdlSource-2008
and, maybe,verilogSource-2005
.