search

TerosTechnology / vscode-terosHDL

VHDL and Verilog/SV IDE: state machine viewer, linter, documentation, snippets... and more!
https://terostechnology.github.io/terosHDLdoc/
GNU General Public License v3.0
571 stars 46 forks source link

Vivado version not detected correctly when verifying the setup #701

Open fuzesa opened 1 week ago

fuzesa commented 1 week ago

Describe the bug When the user clicks the Verify Setup button within the Configuration section, it attempts to get the version of the installed Vivado application that was provided in the settings. The problem is that in https://github.com/TerosTechnology/vscode-terosHDL/blob/e2c4806782f8d3290665f926d173aa375eec6ee1/src/teroshdl/features/configChecker/externalTools.ts#L42 file, the --version flag is hardcoded, but the two dashes don't work, because the Vivado executable requires only a single dash in order to print the correct version (please see screenshot below). This leads to Verify Setup failing. (See second screenshot)

To Reproduce Set the correct path to the Vivado executable and afterwards click on the Verify Setup button.

Please complete the following information:

Screenshots image image

fuzesa commented 1 week ago

Perhaps some modifications similar to this could be added:

https://github.com/fuzesa/vscode-terosHDL/commit/80044f3912fbed14185d90203aee222c9fef81c4