search

Test-Account666 / PlugManX

Plugin manager for Bukkit servers.
https://www.spigotmc.org/resources/plugman-improved.88135/
MIT License
103 stars 43 forks source link

Add 1.20.5 / 1.20.6 support #37

Closed TechnicallyCoded closed 2 months ago

TechnicallyCoded commented 2 months ago

Tested to reload a plugin in 1.20.5. Please leave any bugs below.

--- WARNING --- This hasn't been tested for 1.20.4 or lower although is has been written with such backwards compatibility in mind.

TechnicallyCoded commented 2 months ago

I will note that enough code has changed that it's best to test this version to death instead of trying to read every change. If you want to do so anyway, just review the entire file without the diff mode, basically everything changed in BukkitCommandWrap to make it more future-proof.

TechnicallyCoded commented 2 months ago

I just realized that the spigot version says version 2.3.7... I don't understand the versioning lol. I'll update it to 2.3.8 if requested.

Test-Account666 commented 2 months ago

The comments you added are too many and most of them are unnecessary.

You also gave up half way through.

I suggest removing them completely

TechnicallyCoded commented 2 months ago

( For the record, this fixes #35 )

TechnicallyCoded commented 2 months ago

Changes were made. Lmk if anything new is needed