search

Test-Account666 / PlugManX

Plugin manager for Bukkit servers.
https://www.spigotmc.org/resources/plugman-improved.88135/
MIT License
103 stars 43 forks source link

Improve /plugman check all command #4

Closed Dymeth closed 2 years ago

Dymeth commented 2 years ago

More flexible system for checking for updates. Fewer false positives about the need for an update

Test-Account666 commented 2 years ago

More flexible system for checking for updates. Fewer false positives about the need for an update

I couldn't find time to test it, yet, did you test it?

Dymeth commented 2 years ago

More flexible system for checking for updates. Fewer false positives about the need for an update

I couldn't find time to test it, yet, did you test it?

I tested on own server with over 50 plugins

Test-Account666 commented 2 years ago

More flexible system for checking for updates. Fewer false positives about the need for an update

I couldn't find time to test it, yet, did you test it?

I tested on own server with over 50 plugins

I just looked at the code and saw you're handling the hashes from curseforge plugins like the normal version format of spigotmc. Are you sure this will be fine?

Test-Account666 commented 2 years ago

Okay, just tested your regex, seems fine. I'll merge now.

Thanks for your help! :)