Test-Account666 / PlugManX

Plugin manager for Bukkit servers.
https://www.spigotmc.org/resources/plugman-improved.88135/
MIT License
110 stars 45 forks source link

Add /plugman download #8

Closed Toshimichi0915 closed 1 year ago

Test-Account666 commented 1 year ago

I'm unsure how often this command will come in handy since most plugins are downloaded from spigotmc - Which does not return direct urls to the files.

Did you test this?

Toshimichi0915 commented 1 year ago

I know there's a plugin that can download Spigot plugins. However, to download Spigot plugins directly we need to rely on third-party API called "Spiget", which I do not trust because they are essentially redistributing plugins without authors' consent.

If someone wants to download Spigot plugins directly, they can manually use Spiget API to get direct download link. So I don't think it was essential to implement that feature.

Test-Account666 commented 1 year ago

I'll think about adding this command.

I personally won't use it though.

I have to wait before I can merge anyway...

I currently don't have a PC so I cannot test this properly.

Thank you very much for your time and effort :)

Toshimichi0915 commented 1 year ago

Todo: I forgot to update plugin.yml fix tomorrow

Toshimichi0915 commented 1 year ago

I added Spiget support. Can you check?

Note: LICENSE file has been moved to LICENSE.md because Windows file system is case-insensitive and I can't have both "LICENSE" file and license directory at the same time, causing weird issues on my computer.

Test-Account666 commented 1 year ago

Weird, I thought the license file and directory was no problem since I had this once on Win10 🤔

Thanks for adding Spiget, the command is way more useful now.

I still don't have a PC rn though...

I'll probably search for someone, who I can trust, to test it for me.

Again, thank you for your contribution :]

Toshimichi0915 commented 1 year ago

When can you merge?

Test-Account666 commented 1 year ago

When can you merge?

I'm still missing a PC.

Should be able to merge in the next 5 weeks though