Upgrading to dotnetcore 2.0

TestStack / TestStack.BDDfy

BDDfy is the simplest BDD framework EVER!

MIT License

417 stars 84 forks source link

Upgrading to dotnetcore 2.0 #261

Closed MehdiK closed 6 years ago

MehdiK commented 6 years ago

The build is green locally and on CI. ~~Two issues:~~

~~It doesn't version properly. GitVersion works and sets the version on the assembly; but DotNetCorePack creates a 1.0.0 package. @JakeGinnivan could you have a look please?~~ Fixed
~~The build is quite temperamental on CI during the Test stage. It fails randomly. I will need to look into this.~~ Fixed, I hope.

MehdiK commented 6 years ago

Got the NuGet version working. DotNetCorePack seems to be optimised for the old dotnetcore project format. I had to pass in a few custom args to fix the version and to create symbols package.

MehdiK commented 6 years ago

I think the intermittent test failures are fixed now too. The past few builds have been clean. Had to run build.ps1 in a new PowerShell process.

MehdiK commented 6 years ago

I'd appreciate a review when you get a chance. /cc @JakeGinnivan @mwhelan