Upload Images - Githubissues

thunder033 commented 7 years ago

[Dependent on #16] While creating a posting, sellers should be able to upload images to associate with their postings

while editing a posting, a seller can select on or more images to add to their posting
images can be uploaded either through opening a browse dialog or drag/drop into the view
a maximum of 5 images is allowed per posting
an error is displayed to the user if they upload an invalid image
- images must be no larger than 500 kB
- images must be of type JPG or PNG
- error message text: "Selected image cannot be added. Posting images must be 500 kB or smaller and be either JPG or PNG."
when a user selects an image for upload a block is displayed with details and upload progress
- ~~details include the filename and size~~
- the upload progress is displayed while the image is uploading
- the progress bar is removed when the upload completes
- a thumbnail of the image is displayed in the block
- users can remove the image at any point
users can re-order images to determine how the images will be displayed on the posting
while images are uploading, the save posting control is disabled

caseymazza commented 7 years ago

why max of 5 photos? error message should tell user what the problem is so they can fix it. upload progress could be nice but I think a block display is unnecessary.

thunder033 commented 7 years ago

5 image max is slightly arbitrary, but basically because images are large and cost money to store. We basically have to store them forever
I'll edit the post to included error message text
what would an alternative to blocks be? To support things like removing and re-ordering images, it's basically something you get for free. There's a lot of out plugin-and-play modules for file uploads that support it (i.e. FileDrop)

caseymazza commented 7 years ago

I mean more so for things like file details of size and name. I think it'll end up being more info than people want to see

thunder033 commented 7 years ago

oh ok, yeah you're probably right in that respect, the blocks can just be previews of the image with a remove control

The-Lounge / TheLounge

Upload Images #22