TheJacksonLaboratory / splicing-pipelines-nf

Repository for the Anczukow-Lab splicing pipeline
14 stars 9 forks source link

Adds sra test #253

Closed Vlad-Dembrovskyi closed 2 years ago

Vlad-Dembrovskyi commented 3 years ago

Description

Adds a new test profile that tests the SRA input download option. Closes #252

Purpose

Pipeline is designed to also support providing input fastq files as SRA accessions and download them with SRA toolkit, but this way of running the pipeline hasn't been covered yet by the CI tests.

Changes

To test

git clone https://github.com/TheJacksonLaboratory/splicing-pipelines-nf
cd splicing-pipelines-nf
git checkout add-sra-test

NXF_VER=20.01.0 nextflow run . -profile base,sra_test,docker

To test on sumner

git clone https://github.com/TheJacksonLaboratory/splicing-pipelines-nf
cd splicing-pipelines-nf
git checkout add-sra-test

NXF_VER=20.01.0 nextflow run . -profile base,sra_test,sumner
Vlad-Dembrovskyi commented 3 years ago

I can't undesrstand why both ultra quick test and singularity tests are failing now.

Locally ultra_quick test is running fine: nextflow run . -profile base,ultra_quick_test,docker image

Vlad-Dembrovskyi commented 3 years ago

Locally the singularity one is failing too, although with a different error I think it may be due to how sra-toolkit was installed in docker container. sra-toolkit needs some kind of configuration to be run first before using it, and this configuration is user-specific. In the used docker container the sra-toolkit was installed for root user only. So if you are running the container with singularity with not a root user - you don't have the configuration set and that's why it fails. I tried to see how could one set this configuration for new user non-interactively, and I couldn't find a solution so far:

Vlad-Dembrovskyi commented 2 years ago

The remaining SRA tests are finally not failing, @angarb and @cgpu approved the merge for closest release and to leave the singularity<>SRA issue for next release. Merging.