TheJacksonLaboratory / splicing-pipelines-nf

Repository for the Anczukow-Lab splicing pipeline
14 stars 9 forks source link

Remove network and subnetwork from Google configs #315

Closed cgpu closed 1 year ago

cgpu commented 2 years ago

Description

This PR removes the google.network and google.subnetwork parameters to allow CloudOS to set it automatically. Formerly this extra option was overwriting the CloudOS configuration, which was workspace specific. The change enables seamless usage of the same pipeline parameters set across google projects (and hence CloudOS workspaces) without the need to redefine the required --network and --subnetwork which are not always known to the pipeline users.

Changes

How to test

To test, resume a previously completed CloudOS job that formerly was running with the added parameter flag-value pairs --network xxx --subnetwork yyy.

1. Resume and switch the branch to the current one named fix-issues/301

2. Remove the above options --network xxx --subnetwork yyy.

Expected behaviour

The CloudOS job should be completed as it did before removing the options.

cgpu commented 2 years ago

@angarb this is ready to test in CloudOS, if you can resume one previously completed job by following the steps above we should have results for tomorrow to review before we can merge the change.

angarb commented 1 year ago

Checked PR

Old: https://cloudos.lifebit.ai/public/jobs/617c08502fc32701e6715b91 New: https://cloudos.lifebit.ai/public/jobs/6333566b67a90701556a9a0f